Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exemplify language tagging #469

Merged
merged 5 commits into from
Mar 19, 2019
Merged

Exemplify language tagging #469

merged 5 commits into from
Mar 19, 2019

Conversation

chaals
Copy link
Contributor

@chaals chaals commented Mar 19, 2019

This would need to be accompanied by a change to the context file, noting that the alumniOf and degree.name are of type rdf:HTML

update Done.


Preview | Diff

This would need to be accompanied by a change to the context file, noting that the `alumniOf` and `degreeType` are of type `HTMLLiteral`
@chaals chaals requested review from burnburn and r12a March 19, 2019 10:02
@chaals
Copy link
Contributor Author

chaals commented Mar 19, 2019

This addresses some of the comments raised in #436

@chaals
Copy link
Contributor Author

chaals commented Mar 19, 2019

Whoops. Apart from being incomplete, I need to escape HTML in pre elements...

update coming

Oops. Need to escape HTML code used as an example.
make some text strings HTML literal to demonstrate language processing.
@burnburn
Copy link
Contributor

@chaals when this is ready please add the i18n-comments label so Richard will see it.

@chaals
Copy link
Contributor Author

chaals commented Mar 19, 2019

Should be complete now.

Copy link

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been kept busy today, so i haven't been able to consider this in depth, but the changes look ok. I guess i'm wondering whether there are examples of other (non-HTML) approaches, but i think this is all editorial work, so it has no particular time pressure. On the basis that we can revisit editorial changes, i'm happy with this.

@burnburn
Copy link
Contributor

Thank you. Yes, we can revisit editorial changes after the CR publication and, in fact, expect to.

@chaals
Copy link
Contributor Author

chaals commented Mar 19, 2019

Right. There aren't examples of the non-HTML methods, yet. I will add a simple one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants